Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDP-907] data/db: Automatic cancellation of Ready Payments after a certain time period #78

Merged
merged 9 commits into from
Oct 30, 2023
Merged

[SDP-907] data/db: Automatic cancellation of Ready Payments after a certain time period #78

merged 9 commits into from
Oct 30, 2023

Conversation

ceciliaromao
Copy link
Contributor

What

Automatic cancellation of pending payments after a certain time period

Why

If a payment has been in 'ready' status for more than a certain quantity of days, move from 'ready' to 'canceled' status. Do not pay the receiver if they verify their identity after that.

Known limitations

N/A

Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).
  • This PR's title starts with the name of the package, area, or subject affected by the change.

Thoroughness

  • This PR adds tests for the new functionality or fixes.
  • This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

  • No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
  • No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
  • No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
  • No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

  • This is not a breaking change.
  • This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

  • Does the deployment work after merging?

@ceciliaromao ceciliaromao self-assigned this Oct 24, 2023
@ceciliaromao ceciliaromao had a problem deploying to Receiver Registration - E2E Integration Tests October 24, 2023 13:29 — with GitHub Actions Failure
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests October 24, 2023 13:29 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao marked this pull request as draft October 24, 2023 13:29
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr78.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr78.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr78.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests October 24, 2023 14:52 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests October 24, 2023 14:52 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr78.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr78.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr78.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao marked this pull request as ready for review October 24, 2023 15:09
@ceciliaromao ceciliaromao requested review from CaioTeixeira95, marwen-abid, ziyliu and reecexlm and removed request for CaioTeixeira95 October 24, 2023 15:09
CaioTeixeira95
CaioTeixeira95 reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@CaioTeixeira95 CaioTeixeira95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! I've left some comments. Let me know if you have any questions.

internal/db/migrations/2023-10-25-alter-organizations-table.sql Outdated Show resolved Hide resolved
internal/db/migrations/2023-10-25-update-payments-status-type.sql Outdated Show resolved Hide resolved
internal/db/migrations/2023-10-25-update-payments-status-type.sql Outdated Show resolved Hide resolved
internal/data/organizations.go Outdated Show resolved Hide resolved
internal/data/payments.go Outdated Show resolved Hide resolved
internal/data/payments_test.go Outdated Show resolved Hide resolved
internal/db/migrations/2023-10-25-alter-organizations-table.sql Outdated Show resolved Hide resolved
internal/scheduler/jobs/ready_payments_cancellation_job.go Outdated Show resolved Hide resolved
internal/scheduler/jobs/ready_payments_cancellation_job_test.go Outdated Show resolved Hide resolved
internal/scheduler/jobs/ready_payments_cancellation_job_test.go Show resolved Hide resolved
marwen-abid
marwen-abid reviewed Oct 24, 2023
View reviewed changes
internal/data/organizations.go Outdated Show resolved Hide resolved
internal/data/payments.go Outdated Show resolved Hide resolved
internal/db/migrations/2023-10-25-alter-organizations-table.sql Outdated Show resolved Hide resolved
internal/services/ready_payments_cancellation_service.go Outdated Show resolved Hide resolved
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests October 26, 2023 02:33 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests October 26, 2023 02:33 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr78.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr78.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr78.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests October 26, 2023 02:43 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests October 26, 2023 02:43 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr78.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr78.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr78.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests October 26, 2023 19:50 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests October 26, 2023 19:50 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr78.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr78.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr78.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests October 26, 2023 20:46 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests October 26, 2023 20:46 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr78.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr78.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr78.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao mentioned this pull request Oct 26, 2023
Merged
CaioTeixeira95
CaioTeixeira95 approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@CaioTeixeira95 CaioTeixeira95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you for working on this! 🚀

internal/data/payments_test.go Outdated Show resolved Hide resolved
internal/data/payments.go Show resolved Hide resolved
internal/serve/httphandler/profile_handler.go Outdated Show resolved Hide resolved
@ceciliaromao ceciliaromao had a problem deploying to Anchor Integration Tests October 30, 2023 13:58 — with GitHub Actions Failure
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests October 30, 2023 13:58 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr78.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr78.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr78.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests October 30, 2023 13:59 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests October 30, 2023 13:59 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr78.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr78.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr78.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao temporarily deployed to Receiver Registration - E2E Integration Tests October 30, 2023 14:00 — with GitHub Actions Inactive
@ceciliaromao ceciliaromao temporarily deployed to Anchor Integration Tests October 30, 2023 14:00 — with GitHub Actions Inactive
@stellar-jenkins
Copy link

stellar-disbursement-platform-backend-preview is available here:
SDP: https://sdp-backend-pr78.previews.kube001.services.stellar-ops.com/health
AP: https://sdp-ap-pr78.previews.kube001.services.stellar-ops.com/health
Frontend: https://sdp-backend-dashboard-pr78.previews.kube001.services.stellar-ops.com

@ceciliaromao ceciliaromao merged commit ac8785e into develop Oct 30, 2023
6 checks passed
@ceciliaromao ceciliaromao deleted the SDP-907_payments-cancellation branch October 30, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaioTeixeira95 CaioTeixeira95 CaioTeixeira95 approved these changes

@ziyliu ziyliu Awaiting requested review from ziyliu

@reecexlm reecexlm Awaiting requested review from reecexlm

@marwen-abid marwen-abid Awaiting requested review from marwen-abid

Assignees

@ceciliaromao ceciliaromao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ceciliaromao @stellar-jenkins @marwen-abid @CaioTeixeira95